Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dev dependencies #101

Closed
wants to merge 1 commit into from

Conversation

antonkomarev
Copy link
Collaborator

@antonkomarev antonkomarev commented Jan 4, 2024

This might be useful on development phase, when we want to try some kind of untagged changes (from dev-master branch) of any package.

"prefer-stable": true will protect us install unstable packages if there are stable releases.

@antonkomarev
Copy link
Collaborator Author

Build fail not related to this PR. I haven't changed any PHP code.

@antonkomarev
Copy link
Collaborator Author

antonkomarev commented Jan 4, 2024

I've tried to remove my changes, but build is still failing. It might be related to new PHP CS Fixer.

Previous PR:

PHP CS Fixer 3.41.1 Long Night by Fabien Potencier and Dariusz Ruminski.

This PR:

PHP CS Fixer 3.46.0 Three Keys by Fabien Potencier and Dariusz Ruminski.

@garak
Copy link
Collaborator

garak commented Jan 4, 2024

Unless we have some specific needs related to some specific vendors, I'm against this change.
@JellyBellyDev WDYT?

@JellyBellyDev
Copy link
Collaborator

Also in my opinion, this is not a good practice! I'm sorry @antonkomarev

@garak garak closed this Jan 4, 2024
@antonkomarev antonkomarev deleted the allow-dev-dependencies branch January 4, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants